DM-48117: don't use LocalPhotoCalib and LocalWcs in CalibrateImageTask. #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalibrateImageTask writes calibrated flux fields, so we don't need to do the LocalNanojanksy functor any more.
laurenam
approved these changes
Dec 18, 2024
| - slot_CalibFlux_instFluxErr | ||
| - base_LocalPhotoCalib | ||
| - base_LocalPhotoCalibErr | ||
| - slot_CalibFlux_flux |
There was a problem hiding this comment.
Were the *Err entries never supposed to be here?
There was a problem hiding this comment.
They were supposed to be there and are still there in the outputs (a few lines down, in this case), but the diff obfuscates that a bit. I'm not sure why the LocalNanoJansky functor required flux and calibration errors to compute the fluxes, but I think that's out of scope.
There was a problem hiding this comment.
Oh, yeah, I was just asking if the Err fields were actually required for the LocalNanoJansky functor. Looks to me like they aren't: https://github.com/lsst/pipe_tasks/blob/main/python/lsst/pipe/tasks/functors.py#L1751-L1766
(I get that those fields in general are getting added below).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.